Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unlock numpy after dropping 3.8 #1480

Merged
merged 17 commits into from
Nov 6, 2024
Merged

Unlock numpy after dropping 3.8 #1480

merged 17 commits into from
Nov 6, 2024

Conversation

SharonHart
Copy link
Contributor

@SharonHart SharonHart commented Nov 4, 2024

Change Description

We needed to lock a numpy version for it to be built on 3.8. Now that it is deprecated, we can remove the locking.

Checklist

  • I have reviewed the contribution guidelines
  • I have signed the CLA (if required)
  • My code includes unit tests
  • All unit tests and lint checks pass locally
  • My PR contains documentation updates / additions if required

@SharonHart SharonHart requested a review from a team as a code owner November 4, 2024 06:55
@SharonHart
Copy link
Contributor Author

/azp run

Copy link

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

Base automatically changed from update_py_version to main November 4, 2024 09:47
omri374
omri374 previously approved these changes Nov 4, 2024
@omri374
Copy link
Contributor

omri374 commented Nov 4, 2024

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@SharonHart
Copy link
Contributor Author

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@SharonHart
Copy link
Contributor Author

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@SharonHart
Copy link
Contributor Author

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@SharonHart
Copy link
Contributor Author

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@omri374
Copy link
Contributor

omri374 commented Nov 6, 2024

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@omri374 omri374 merged commit ce63783 into main Nov 6, 2024
32 checks passed
@omri374 omri374 deleted the shhart/bugfix-unlock-numpy branch November 6, 2024 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants