Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(docs) Use Presidio across Anthropic, Bedrock, VertexAI, Azure OpenAI, etc. w/ LiteLLM Proxy #1421

Merged
merged 7 commits into from
Jul 24, 2024

Conversation

krrishdholakia
Copy link
Contributor

@krrishdholakia krrishdholakia commented Jul 22, 2024

Change Description

Adds a sample doc for setting up Presidio (docker image) with LiteLLM Proxy for implementing PII Masking across 100+ LLMs.

Issue reference

n/a

Checklist

cc: @omri374 @SharonHart

@omri374
Copy link
Contributor

omri374 commented Jul 23, 2024

Thanks! We'll review this soon

Copy link
Contributor

@SharonHart SharonHart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, left a few nits
Thanks for the contribution!

docs/samples/docker/litellm.md Outdated Show resolved Hide resolved
docs/samples/docker/litellm.md Show resolved Hide resolved
mkdocs.yml Outdated Show resolved Hide resolved
@krrishdholakia
Copy link
Contributor Author

@SharonHart @omri374 updated based on feedback - any remaining blockers for merge?

mkdocs.yml Outdated Show resolved Hide resolved
SharonHart
SharonHart previously approved these changes Jul 23, 2024
Copy link
Contributor

@omri374 omri374 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Great addition.

I would suggest to add an explanation on the top specifying the user cases for using presidio with litellm, and how this flow works in high level.

docs/samples/docker/litellm.md Show resolved Hide resolved
docs/samples/docker/litellm.md Outdated Show resolved Hide resolved
docs/samples/docker/litellm.md Outdated Show resolved Hide resolved
@SharonHart
Copy link
Contributor

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@krrishdholakia
Copy link
Contributor Author

Hey @omri374 @SharonHart updated based on feedback - is this okay to merge?

Copy link
Contributor

@omri374 omri374 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Great contribution and addition

@omri374 omri374 merged commit cd7e547 into microsoft:main Jul 24, 2024
3 checks passed
@krrishdholakia
Copy link
Contributor Author

Hey @omri374 @SharonHart i still don't see litellm on the docs - https://microsoft.github.io/presidio/samples/

Did i put this somewhere wrong?

@omri374
Copy link
Contributor

omri374 commented Aug 5, 2024

Hey @krrishdholakia, the website is now updated and contains the litellm docs. Thanks for the note!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants