Improve url detector #1398
Merged
Improve url detector #1398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@microsoft-github-policy-service agree [company="Pillar Security"] |
|
@microsoft-github-policy-service agree company="Pillar Security" |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
Currently, the presidio URL detector does not appropriately recognize URLs from less common, albeit valid, gTLDs. For example, if attempting to recognize the URL of https://webhook.site/a8eedfd6-9d8a-44e0-b0fc-cc7d517db5dc?q=1&b=2, the recognizer will only match on
https://webhook.si, thus missing the complete URL including query params.This change fixes it.
The list of URLs was pulled from the list of gTLDs supported by namecheap as of today:
https://www.namecheap.com/domains/full-tld-list/
Issue reference
There was no related issue opened, this was simply uncovered through the use of presidio analyzers.
Checklist