-
Notifications
You must be signed in to change notification settings - Fork 591
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Loading analyzer engine & recognizer registry from configuration file #1367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* initial version of loader * addressed comments * linting fixes * re structured recognizers in yaml * addressed comments and fixed predefined recognizers loading * added engine provider to analyzer init * moved logic to recognizer registry provider * some name fixes to recognizer provider * added language support to recognizer registry * fixed interface issues, added unit tests for providers * fixed tests, addressed comments * added yaml configuration to package, fixed linting rules * move all conf file to a single location * remove file from previous location * merged from main, added default conf file for engine provider * addressed some comments * setup fixups * remove redundant line * fix long line * fixing linting errors * Update presidio-analyzer/presidio_analyzer/analyzer_engine_provider.py Co-authored-by: Sharon Hart <sharonh.dev@gmail.com> * updates to the existing logic for loading engines through configuration * updates to Dockerfile --------- Co-authored-by: roeybc <robencha@microsoft.com> Co-authored-by: Sharon Hart <sharonh.dev@gmail.com>
…feature/engines_from_conf # Conflicts: # presidio-analyzer/setup.py
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
omri374
previously approved these changes
Apr 28, 2024
omri374
approved these changes
Apr 29, 2024
SharonHart
reviewed
May 1, 2024
SharonHart
reviewed
May 1, 2024
SharonHart
reviewed
May 1, 2024
SharonHart
reviewed
May 1, 2024
presidio-analyzer/presidio_analyzer/recognizer_registry/recognizer_registry.py
Show resolved
Hide resolved
SharonHart
reviewed
May 1, 2024
presidio-analyzer/presidio_analyzer/recognizer_registry/recognizer_registry_provider.py
Show resolved
Hide resolved
SharonHart
approved these changes
May 1, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing outcome :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
This PR adds a file-based configuration for presidio-analyzer. It allows users to: