Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support 'M' prefix in SG_NRIC_FIN Recognizer and expand tests #1304

Merged
merged 3 commits into from
Feb 19, 2024

Conversation

miltonsim
Copy link
Contributor

@miltonsim miltonsim commented Feb 17, 2024

Change Description

  • Updated SG_NRIC_FIN Recognizer to include 'M' prefix for validating NRIC numbers issued to foreigners from 2022 onwards.
  • Added new test cases to ensure comprehensive coverage and validation accuracy for all supported NRIC prefixes (S, T, F, G, M).

Issue reference

This PR fixes issue #1303

Checklist

  • I have reviewed the contribution guidelines
  • I have signed the CLA (if required)
  • My code includes unit tests
  • All unit tests and lint checks pass locally
  • My PR contains documentation updates / additions if required

- Updated SG_NRIC_FIN Recognizer to include 'M' prefix for validating NRIC numbers issued to foreigners from 2022 onwards.
- Added new test cases to ensure comprehensive coverage and validation accuracy for all supported NRIC prefixes (S, T, F, G, M).
@miltonsim
Copy link
Contributor Author

@microsoft-github-policy-service agree

@miltonsim miltonsim marked this pull request as ready for review February 17, 2024 02:05
- Introduced a new test case to validate the recognition of valid NRIC/FIN numbers when embedded within a sentence
@omri374
Copy link
Contributor

omri374 commented Feb 18, 2024

/azp run

@omri374
Copy link
Contributor

omri374 commented Feb 18, 2024

Thanks!

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@omri374 omri374 merged commit 45c418d into microsoft:main Feb 19, 2024
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants