Feature/presidio-structured #1192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
changelog Static analysis docstrings, types preliminary tests engine static analysis isort Minor refactorings Update README.md Fix late binding issues and example removal of old samples Refactoring, adding example pre-clean-break-commit broken commit, fixing TabularConfigBuilder Rename TabularConfig pre-breaking replace commit removal of some old experimental files rename tabular to structured restructuring presidio tabular - pre del commit Add project TODOs testing dump presidio tabular
Jakob-98
force-pushed
the
feature/presidio-tabular
branch
from
ccb469a to
8c6be26
Compare
|
Thanks @Jakob-98! |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Jakob-98
changed the title
|
Opening up for review Items left from my side:
|
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
…8/presidio into feature/presidio-tabular
omri374
reviewed
Nov 19, 2023
added 7 commits
November 22, 2023 13:03
optional AnalyzerEngine parameter
|
Azure Pipelines successfully started running 1 pipeline(s). |
…8/presidio into feature/presidio-tabular
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
SharonHart
reviewed
Dec 24, 2023
SharonHart
reviewed
Dec 24, 2023
presidio-structured/presidio_structured/data/data_processors.py
Outdated
Show resolved
Hide resolved
SharonHart
reviewed
Dec 24, 2023
presidio-structured/presidio_structured/data/data_processors.py
Outdated
Show resolved
Hide resolved
SharonHart
reviewed
Dec 24, 2023
SharonHart
reviewed
Dec 24, 2023
omri374
reviewed
Dec 24, 2023
presidio-structured/presidio_structured/config/structured_analysis.py
Outdated
Show resolved
Hide resolved
presidio-structured/presidio_structured/data/data_processors.py
Outdated
Show resolved
Hide resolved
|
Agree with Sharon, this looks great! Added a few comments, all minor. |
|
Happy 2024, and thanks for the review! Will address once some dev time frees up on my end :) |
SharonHart
approved these changes
Jan 10, 2024
1 task
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
The proposed approach is to build a library (presidio-structured) which re-uses existing logic from existing presidio components to allow anonymization of (semi-)structured data. A priority is to have a recognizable user experience/interface compared to the existing library components. This has been a much requested feature, see for instance:
Supporting structured / semi-structured data with Presidio · microsoft/presidio · Discussion #714 (github.com)
In the sample folder there is a notebook showcasing the logic to be supported in V1 of presidio-structured
Issue reference
This PR fixes issue #714
Checklist