Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: pass JSHandles instead of ObjectId to/from context delegate #34895

Merged
merged 4 commits into from
Feb 24, 2025

Conversation

yury-s
Copy link
Member

@yury-s yury-s commented Feb 22, 2025

No description provided.

This comment has been minimized.

This comment has been minimized.

@yury-s yury-s changed the title chore: encapsulate ObjectId in browser-specific code chore: pass JSHandles instead of ObjectId to/from browser-specific code Feb 24, 2025
@yury-s yury-s changed the title chore: pass JSHandles instead of ObjectId to/from browser-specific code chore: pass JSHandles instead of ObjectId to/from context delegate Feb 24, 2025

This comment has been minimized.

This comment has been minimized.

Copy link
Contributor

Test results for "tests 1"

9 flaky ⚠️ [firefox-page] › tests/page/page-evaluate.spec.ts:403:3 › should throw for too deep reference chain @firefox-ubuntu-22.04-node18
⚠️ [chromium-library] › tests/library/video.spec.ts:379:5 › screencast › should capture navigation @ubuntu-20.04-chromium-tip-of-tree
⚠️ [playwright-test] › tests/ui-mode-test-watch.spec.ts:145:5 › should watch all @ubuntu-latest-node20-1
⚠️ [webkit-library] › tests/library/browsercontext-clearcookies.spec.ts:92:3 › should remove cookies by domain @webkit-ubuntu-22.04-node18
⚠️ [webkit-library] › tests/library/proxy.spec.ts:44:3 › should use proxy for second page @webkit-ubuntu-22.04-node18
⚠️ [webkit-library] › tests/library/proxy.spec.ts:178:3 › should exclude patterns @webkit-ubuntu-22.04-node18
⚠️ [webkit-page] › tests/page/page-filechooser.spec.ts:24:5 › should upload multiple large files @webkit-ubuntu-22.04-node18
⚠️ [webkit-page] › tests/page/page-screenshot.spec.ts:224:5 › page screenshot › should take fullPage screenshots and mask elements outside of it @webkit-ubuntu-22.04-node18
⚠️ [playwright-test] › tests/ui-mode-test-watch.spec.ts:145:5 › should watch all @windows-latest-node18-1

38670 passed, 793 skipped
✔️✔️✔️

Merge workflow run.

@yury-s yury-s merged commit dbbdabf into microsoft:main Feb 24, 2025
29 of 31 checks passed
@yury-s yury-s deleted the pass-handles branch February 24, 2025 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants