-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: various v1.48.0 roll fixes for .NET #33096
Conversation
docs/src/api/params.md
Outdated
@@ -363,7 +363,7 @@ Target URL. | |||
|
|||
## js-fetch-option-params | |||
* langs: js | |||
- `params` <[Object]<[string], [string]|[number]|[boolean]>|[URLSearchParams]|[string]> | |||
- `params` <[Object]<[string], [string]|[int]|[boolean]>|[URLSearchParams]|[string]> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we had a various places where we used [number] but we should have used [int]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this should be float instead, nothing forces a query param to be integer.
|
||
## async method: WebSocketRoute.onMessage | ||
## method: WebSocketRoute.onMessage |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ouch! I hope this is backwards-compatible.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks like it, no types.d.ts changes.
docs/src/api/params.md
Outdated
@@ -363,7 +363,7 @@ Target URL. | |||
|
|||
## js-fetch-option-params | |||
* langs: js | |||
- `params` <[Object]<[string], [string]|[number]|[boolean]>|[URLSearchParams]|[string]> | |||
- `params` <[Object]<[string], [string]|[int]|[boolean]>|[URLSearchParams]|[string]> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this should be float instead, nothing forces a query param to be integer.
This comment has been minimized.
This comment has been minimized.
Test results for "tests 1"1 failed 3 flaky35861 passed, 620 skipped Merge workflow run. |
No description provided.