fix(test runner): run project dependencies of --only-changed test files
#32094
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Skn0tt
changed the title
--only-changed with project dependencies
This comment has been minimized.
This comment has been minimized.
Skn0tt
commented
Aug 12, 2024
This comment has been minimized.
This comment has been minimized.
dgozman
reviewed
Aug 12, 2024
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Skn0tt
changed the title
--only-changed with project dependencies--only-changed test file
Skn0tt
changed the title
--only-changed test file--only-changed test files
dgozman
approved these changes
Aug 12, 2024
Test results for "tests 1"1 failed 2 flaky29698 passed, 711 skipped Merge workflow run. |
Skn0tt
added a commit
to Skn0tt/playwright
that referenced
this pull request
Aug 15, 2024
…iles (microsoft#32094) Closes microsoft#32070. We were applying `additionalFileMatcher` not just to `filteredProjectSuites`, but also to `projectSuites`. `projectSuites` is where we take dependency projects from, though - so `--only-changed` led to empty dependency projects, resulting in the reported bug. The fix is to only apply `additionalFileMatcher` on `filteredProjectSuites`.
Skn0tt
added a commit
that referenced
this pull request
Aug 15, 2024
…-only-changed` test files (#32172) Closes #32070. We were applying `additionalFileMatcher` not just to `filteredProjectSuites`, but also to `projectSuites`. `projectSuites` is where we take dependency projects from, though - so `--only-changed` led to empty dependency projects, resulting in the reported bug. The fix is to only apply `additionalFileMatcher` on `filteredProjectSuites`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #32070. We were applying
additionalFileMatchernot just tofilteredProjectSuites, but also toprojectSuites.projectSuitesis where we take dependency projects from, though - so--only-changedled to empty dependency projects, resulting in the reported bug.The fix is to only apply
additionalFileMatcheronfilteredProjectSuites.