Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ui-mode): add annotations tab #31945

Merged
merged 2 commits into from
Aug 1, 2024
Merged

feat(ui-mode): add annotations tab #31945

merged 2 commits into from
Aug 1, 2024

Conversation

yury-s
Copy link
Member

@yury-s yury-s commented Aug 1, 2024

image

@yury-s yury-s requested a review from dgozman August 1, 2024 01:42
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
dgozman
dgozman approved these changes Aug 1, 2024
View reviewed changes
packages/trace-viewer/src/ui/workbench.tsx Outdated Show resolved Hide resolved
packages/trace-viewer/src/ui/annotationsTab.tsx Outdated Show resolved Hide resolved
packages/trace-viewer/src/ui/annotationsTab.tsx Outdated Show resolved Hide resolved
@dgozman
Apply suggestions from code review
af7ad7a 
Signed-off-by: Dmitry Gozman <dgozman@gmail.com>
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 1, 2024

Test results for "tests 1"

4 flaky ⚠️ [firefox-library] › library/browsercontext-fetch-happy-eyeballs.spec.ts:46:3 › get should work
⚠️ [firefox-library] › library/client-certificates.spec.ts:333:3 › browser › support http2 if the browser only supports http1.1
⚠️ [chromium-library] › library/browsercontext-fetch-happy-eyeballs.spec.ts:46:3 › get should work
⚠️ [webkit-library] › library/video.spec.ts:165:5 › screencast › should work with old options

29510 passed, 701 skipped
✔️✔️✔️

Merge workflow run.

@dgozman dgozman changed the title chore(ui-mode): add annotations tab feat(ui-mode): add annotations tab Aug 1, 2024
@dgozman dgozman merged commit 47714d6 into microsoft:main Aug 1, 2024
30 checks passed
dgozman added a commit to dgozman/playwright that referenced this pull request Aug 1, 2024
@yury-s @dgozman
cherry-pick(microsoft#31945): feat(ui-mode): add annotations tab
c613385 
<img width="867" alt="image"
src="https://github.com/user-attachments/assets/7d714723-1d3f-49b2-944a-0a476d79aee8">

---------

Signed-off-by: Dmitry Gozman <dgozman@gmail.com>
Co-authored-by: Dmitry Gozman <dgozman@gmail.com>
yury-s pushed a commit that referenced this pull request Aug 1, 2024
@dgozman
cherry-pick(#31945): feat(ui-mode): add annotations tab (#31968)
5fdf976 
<img width="867" alt="image"

src="https://github.com/user-attachments/assets/7d714723-1d3f-49b2-944a-0a476d79aee8">
@cassus
Copy link

cassus commented Aug 25, 2024

This is awesome! Do you also plan to add this to the trace viewer?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dgozman dgozman dgozman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yury-s @cassus @dgozman