Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

devops: do not download electron on non-electron workflows #22232

Merged
merged 1 commit into from
Apr 6, 2023
Merged

devops: do not download electron on non-electron workflows #22232

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .github/workflows/infra.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,9 @@ on:
- main
- release-*

env:
ELECTRON_SKIP_BINARY_DOWNLOAD: 1

jobs:
doc-and-lint:
name: "docs & lint"
Expand Down
3 changes: 3 additions & 0 deletions .github/workflows/publish_canary.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,9 @@ on:
branches:
- release-*

env:
ELECTRON_SKIP_BINARY_DOWNLOAD: 1

jobs:
publish-canary:
name: "publish canary NPM & Publish canary Docker"
Expand Down
3 changes: 3 additions & 0 deletions .github/workflows/publish_release_docker.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,9 @@ on:
release:
types: [published]

env:
ELECTRON_SKIP_BINARY_DOWNLOAD: 1

jobs:
publish-docker-release:
name: "publish to DockerHub"
Expand Down
3 changes: 3 additions & 0 deletions .github/workflows/publish_release_driver.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,9 @@ on:
release:
types: [published]

env:
ELECTRON_SKIP_BINARY_DOWNLOAD: 1

jobs:
publish-driver-release:
name: "publish playwright driver to CDN"
Expand Down
7 changes: 5 additions & 2 deletions .github/workflows/publish_release_npm.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,9 @@ on:
release:
types: [published]

env:
ELECTRON_SKIP_BINARY_DOWNLOAD: 1

jobs:
publish-npm-release:
name: "publish to NPM"
Expand All @@ -20,10 +23,10 @@ jobs:
- run: npm run build
- run: npx playwright install-deps
- run: utils/publish_all_packages.sh --release-candidate
if: "github.event.release.prerelease"
if: github.event.release.prerelease
env:
NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }}
- run: utils/publish_all_packages.sh --release
if: "!github.event.release.prerelease"
if: !github.event.release.prerelease
env:
NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }}
3 changes: 3 additions & 0 deletions .github/workflows/roll_browser_into_playwright.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,9 @@ on:
repository_dispatch:
types: [roll_into_pw]

env:
ELECTRON_SKIP_BINARY_DOWNLOAD: 1

jobs:
roll:
runs-on: ubuntu-20.04
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/tests_components.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ on:

env:
FORCE_COLOR: 1
ELECTRON_SKIP_BINARY_DOWNLOAD: 1

jobs:
test_components:
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/tests_primary.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ env:
# Force terminal colors. @see https://www.npmjs.com/package/colors
FORCE_COLOR: 1
FLAKINESS_CONNECTION_STRING: ${{ secrets.FLAKINESS_CONNECTION_STRING }}
ELECTRON_SKIP_BINARY_DOWNLOAD: 1

jobs:
test_linux:
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/tests_secondary.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ env:
# Force terminal colors. @see https://www.npmjs.com/package/colors
FORCE_COLOR: 1
FLAKINESS_CONNECTION_STRING: ${{ secrets.FLAKINESS_CONNECTION_STRING }}
ELECTRON_SKIP_BINARY_DOWNLOAD: 1

jobs:
test_linux:
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/tests_stress.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ on:

env:
FORCE_COLOR: 1
ELECTRON_SKIP_BINARY_DOWNLOAD: 1

jobs:
test_components:
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/tests_video.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ env:
# Force terminal colors. @see https://www.npmjs.com/package/colors
FORCE_COLOR: 1
FLAKINESS_CONNECTION_STRING: ${{ secrets.FLAKINESS_CONNECTION_STRING }}
ELECTRON_SKIP_BINARY_DOWNLOAD: 1

jobs:
video_linux:
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/tests_webview2.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ env:
# Force terminal colors. @see https://www.npmjs.com/package/colors
FORCE_COLOR: 1
FLAKINESS_CONNECTION_STRING: ${{ secrets.FLAKINESS_CONNECTION_STRING }}
ELECTRON_SKIP_BINARY_DOWNLOAD: 1

jobs:
test_webview2:
Expand Down