Skip to content

Commit

Permalink
chore: remove input files and selected option overrides (#6665)
Browse files Browse the repository at this point in the history
  • Loading branch information
pavelfeldman authored May 19, 2021
1 parent 1f22673 commit e679d99
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 28 deletions.
9 changes: 0 additions & 9 deletions docs/src/api/csharp.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,12 +6,3 @@ Returns parsed request's body for `form-urlencoded` and JSON as a fallback if an

When the response is `application/x-www-form-urlencoded` then a key/value object of the values will be returned.
Otherwise it will be parsed as JSON.

### param: ElementHandle.selectOption.values = %%-csharp-select-options-values-%%
### param: ElementHandle.setInputFiles.files = %%-csharp-input-files-%%

### param: Frame.selectOption.values = %%-csharp-select-options-values-%%
### param: Frame.setInputFiles.files = %%-csharp-input-files-%%

### param: Page.selectOption.values = %%-csharp-select-options-values-%%
### param: Page.setInputFiles.files = %%-csharp-input-files-%%
20 changes: 1 addition & 19 deletions docs/src/api/params.md
Original file line number Diff line number Diff line change
Expand Up @@ -464,7 +464,7 @@ contexts override the proxy, global proxy will be never used and can be any stri
:::

## select-options-values
* langs: java, js
* langs: java, js, csharp
- `values` <[null]|[string]|[ElementHandle]|[Array]<[string]>|[Object]|[Array]<[ElementHandle]>|[Array]<[Object]>>
- `value` <[string]> Matches by `option.value`. Optional.
- `label` <[string]> Matches by `option.label`. Optional.
Expand Down Expand Up @@ -556,24 +556,6 @@ The default value can be changed by using the [`method: BrowserContext.setDefaul
Maximum time in milliseconds, defaults to 30 seconds, pass `0` to disable timeout. The default value can be changed by
using the [`method: AndroidDevice.setDefaultTimeout`] method.

## csharp-select-options-values
* langs: csharp
- `values` <[Array]<[Object]>>
- `value` <[string]> Matches by `option.value`. Optional.
- `label` <[string]> Matches by `option.label`. Optional.
- `index` <[int]> Matches by the index. Optional.

Options to select. If the `<select>` has the `multiple` attribute, all matching options are selected, otherwise only the
first option matching one of the passed options is selected. String values are equivalent to `{value:'string'}`. Option
is considered matching if all specified properties match.

## csharp-input-files
* langs: csharp
- `files` <[Array]<[Object]>>
- `name` <[string]> File name
- `mimeType` <[string]> File type
- `buffer` <[Buffer]> File content

## shared-context-params-list
- %%-context-option-acceptdownloads-%%
- %%-context-option-ignorehttpserrors-%%
Expand Down
2 changes: 2 additions & 0 deletions utils/doclint/generateDotnetApi.js
Original file line number Diff line number Diff line change
Expand Up @@ -546,6 +546,8 @@ function renderMethod(member, parent, name, options, out) {
* @param {boolean} isExploded
*/
function pushArg(innerArgType, innerArgName, argument, isExploded = false) {
if (innerArgType === 'null')
return;
const isNullable = nullableTypes.includes(innerArgType);
const requiredPrefix = (argument.required || isExploded) ? "" : isNullable ? "?" : "";
const requiredSuffix = (argument.required || isExploded) ? "" : " = default";
Expand Down

0 comments on commit e679d99

Please sign in to comment.