fixes 2

microsoft · Feb 21, 2025 · 8e183b6 · 8e183b6
1 parent b3cfb9c
commit 8e183b6
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 4 deletions.
diff --git a/packages/playwright-core/src/server/frames.ts b/packages/playwright-core/src/server/frames.ts
@@ -1211,8 +1211,7 @@ export class Frame extends SdkObject {
       dom.assertDone(await this._retryWithProgressIfNotConnected(progress, target, options.strict, false /* performActionPreChecks */, async handle => {
         return handle._retryPointerAction(progress, 'move and up', false, async point => {
           // NOTE: Normal browsers emit usually a lot of dragover/mousemove events during drag'n
-          // drop operations. We want to emit minimal to make the ecosystem work. When using
-          // Native drag'n drop the browser does emit dropover events instead.
+          // drop operations. We want to emit minimal to make Angular CDK work.
           await this._page.mouse.move(point.x, point.y);
           await this._page.mouse.move(point.x, point.y);
           await this._page.mouse.up();

diff --git a/tests/page/page-drag.spec.ts b/tests/page/page-drag.spec.ts
@@ -64,7 +64,7 @@ it.describe('Drag and drop', () => {
       browserName === 'firefox' ? 'mousemove at 240;350' : 'dragstart at 120;86',
       'dragenter at 240;350',
       // NOTE: Normal browsers emit usually a lot of dragover events during drag'n
-      // drop operations. We want to emit minimal (2) to make the ecosystem work.
+      // drop operations. We want to emit minimal (2) to make Angular CDK work.
       'dragover at 240;350',
       'dragover at 240;350',
       'drop at 240;350',
@@ -334,7 +334,7 @@ it.describe('Drag and drop', () => {
     expect(await events.jsonValue()).toEqual([
       { type: 'mousemove', x: 120, y: 86 },
       // NOTE: Normal browsers emit usually a lot of mousemove events during drag'n
-      // drop operations. We want to emit minimal(2) to make the ecosystem work.
+      // drop operations. We want to emit minimal(2) to make Angular CDK work.
       { type: 'mousemove', x: 240, y: 350 },
       { type: 'mousemove', x: 240, y: 350 },
     ]);