devops: do not download electron on non-electron workflows (#22232)

microsoft · Apr 6, 2023 · 44b63b0 · 44b63b0
1 parent cea3820
commit 44b63b0
Show file tree

Hide file tree

Showing 12 changed files with 26 additions and 2 deletions.
diff --git a/.github/workflows/infra.yml b/.github/workflows/infra.yml
@@ -10,6 +10,9 @@ on:
       - main
       - release-*
 
+env:
+  ELECTRON_SKIP_BINARY_DOWNLOAD: 1
+
 jobs:
   doc-and-lint:
     name: "docs & lint"

diff --git a/.github/workflows/publish_canary.yml b/.github/workflows/publish_canary.yml
@@ -8,6 +8,9 @@ on:
     branches:
       - release-*
 
+env:
+  ELECTRON_SKIP_BINARY_DOWNLOAD: 1
+
 jobs:
   publish-canary:
     name: "publish canary NPM & Publish canary Docker"

diff --git a/.github/workflows/publish_release_docker.yml b/.github/workflows/publish_release_docker.yml
@@ -11,6 +11,9 @@ on:
   release:
     types: [published]
 
+env:
+  ELECTRON_SKIP_BINARY_DOWNLOAD: 1
+
 jobs:
   publish-docker-release:
     name: "publish to DockerHub"

diff --git a/.github/workflows/publish_release_driver.yml b/.github/workflows/publish_release_driver.yml
@@ -4,6 +4,9 @@ on:
   release:
     types: [published]
 
+env:
+  ELECTRON_SKIP_BINARY_DOWNLOAD: 1
+
 jobs:
   publish-driver-release:
     name: "publish playwright driver to CDN"

diff --git a/.github/workflows/publish_release_npm.yml b/.github/workflows/publish_release_npm.yml
@@ -4,6 +4,9 @@ on:
   release:
     types: [published]
 
+env:
+  ELECTRON_SKIP_BINARY_DOWNLOAD: 1
+
 jobs:
   publish-npm-release:
     name: "publish to NPM"
@@ -20,10 +23,10 @@ jobs:
     - run: npm run build
     - run: npx playwright install-deps
     - run: utils/publish_all_packages.sh --release-candidate
-      if: "github.event.release.prerelease"
+      if: github.event.release.prerelease
       env:
         NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }}
     - run: utils/publish_all_packages.sh --release
-      if: "!github.event.release.prerelease"
+      if: !github.event.release.prerelease
       env:
         NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }}
diff --git a/.github/workflows/roll_browser_into_playwright.yml b/.github/workflows/roll_browser_into_playwright.yml
@@ -4,6 +4,9 @@ on:
   repository_dispatch:
     types: [roll_into_pw]
 
+env:
+  ELECTRON_SKIP_BINARY_DOWNLOAD: 1
+
 jobs:
   roll:
     runs-on: ubuntu-20.04

diff --git a/.github/workflows/tests_components.yml b/.github/workflows/tests_components.yml
@@ -15,6 +15,7 @@ on:
 
 env:
   FORCE_COLOR: 1
+  ELECTRON_SKIP_BINARY_DOWNLOAD: 1
 
 jobs:
   test_components:

diff --git a/.github/workflows/tests_primary.yml b/.github/workflows/tests_primary.yml
@@ -23,6 +23,7 @@ env:
   # Force terminal colors. @see https://www.npmjs.com/package/colors
   FORCE_COLOR: 1
   FLAKINESS_CONNECTION_STRING: ${{ secrets.FLAKINESS_CONNECTION_STRING }}
+  ELECTRON_SKIP_BINARY_DOWNLOAD: 1
 
 jobs:
   test_linux:

diff --git a/.github/workflows/tests_secondary.yml b/.github/workflows/tests_secondary.yml
@@ -18,6 +18,7 @@ env:
   # Force terminal colors. @see https://www.npmjs.com/package/colors
   FORCE_COLOR: 1
   FLAKINESS_CONNECTION_STRING: ${{ secrets.FLAKINESS_CONNECTION_STRING }}
+  ELECTRON_SKIP_BINARY_DOWNLOAD: 1
 
 jobs:
   test_linux:

diff --git a/.github/workflows/tests_stress.yml b/.github/workflows/tests_stress.yml
@@ -16,6 +16,7 @@ on:
 
 env:
   FORCE_COLOR: 1
+  ELECTRON_SKIP_BINARY_DOWNLOAD: 1
 
 jobs:
   test_components:

diff --git a/.github/workflows/tests_video.yml b/.github/workflows/tests_video.yml
@@ -10,6 +10,7 @@ env:
   # Force terminal colors. @see https://www.npmjs.com/package/colors
   FORCE_COLOR: 1
   FLAKINESS_CONNECTION_STRING: ${{ secrets.FLAKINESS_CONNECTION_STRING }}
+  ELECTRON_SKIP_BINARY_DOWNLOAD: 1
 
 jobs:
   video_linux:

diff --git a/.github/workflows/tests_webview2.yml b/.github/workflows/tests_webview2.yml
@@ -18,6 +18,7 @@ env:
   # Force terminal colors. @see https://www.npmjs.com/package/colors
   FORCE_COLOR: 1
   FLAKINESS_CONNECTION_STRING: ${{ secrets.FLAKINESS_CONNECTION_STRING }}
+  ELECTRON_SKIP_BINARY_DOWNLOAD: 1
 
 jobs:
   test_webview2:
-Original file line number
+Diff line change
@@ Expand Up / @@ -15,6 +15,7 @@ on: @@
     env:
       FORCE_COLOR: 1
+      ELECTRON_SKIP_BINARY_DOWNLOAD: 1
     jobs:
       test_components:
@@ Expand Down @@