-
Notifications
You must be signed in to change notification settings - Fork 3.8k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
cherry-pick(#33632): chore: highlight edited locator while recording
- Loading branch information
1 parent
cb0f456
commit 0e64340
Showing
5 changed files
with
93 additions
and
27 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,69 @@ | ||
| /** | ||
| * Copyright (c) Microsoft Corporation. | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| import { test, expect } from './inspectorTest'; | ||
| import { roundBox } from '../../page/pageTest'; | ||
|
|
||
| test.describe(() => { | ||
| test.skip(({ mode }) => mode !== 'default'); | ||
| test.skip(({ trace, codegenMode }) => trace === 'on' && codegenMode === 'trace-events'); | ||
|
|
||
| test('should inspect locator', async ({ openRecorder }) => { | ||
| const { recorder } = await openRecorder(); | ||
| await recorder.setContentAndWait(`<main><button>Submit</button></main>`); | ||
| await recorder.page.click('x-pw-tool-item.pick-locator'); | ||
| await recorder.page.hover('button'); | ||
| await recorder.trustedClick(); | ||
| await recorder.recorderPage.getByRole('tab', { name: 'Locator' }).click(); | ||
| await expect(recorder.recorderPage.locator('.tab-locator .CodeMirror')).toMatchAriaSnapshot(` | ||
| - text: "getByRole('button', { name: 'Submit' })" | ||
| `); | ||
| }); | ||
|
|
||
| test('should update locator highlight', async ({ openRecorder }) => { | ||
| const { recorder } = await openRecorder(); | ||
| await recorder.setContentAndWait(`<main> | ||
| <button>Submit</button> | ||
| <button>Cancel</button> | ||
| </main>`); | ||
|
|
||
| const submitButton = recorder.page.getByRole('button', { name: 'Submit' }); | ||
| const cancelButton = recorder.page.getByRole('button', { name: 'Cancel' }); | ||
|
|
||
| await recorder.recorderPage.getByRole('button', { name: 'Record' }).click(); | ||
|
|
||
| await recorder.page.click('x-pw-tool-item.pick-locator'); | ||
| await submitButton.hover(); | ||
| await recorder.trustedClick(); | ||
| await recorder.recorderPage.getByRole('tab', { name: 'Locator' }).click(); | ||
| await expect(recorder.recorderPage.locator('.tab-locator .CodeMirror')).toMatchAriaSnapshot(` | ||
| - text: "getByRole('button', { name: 'Submit' })" | ||
| `); | ||
|
|
||
| await recorder.recorderPage.locator('.tab-locator .CodeMirror').click(); | ||
| for (let i = 0; i < `Submit' })`.length; i++) | ||
| await recorder.recorderPage.keyboard.press('Backspace'); | ||
|
|
||
| { | ||
| // Different button. | ||
| await recorder.recorderPage.locator('.tab-locator .CodeMirror').pressSequentially(`Cancel' })`); | ||
| await expect(recorder.page.locator('x-pw-highlight')).toBeVisible(); | ||
| const box1 = roundBox(await cancelButton.boundingBox()); | ||
| const box2 = roundBox(await recorder.page.locator('x-pw-highlight').boundingBox()); | ||
| expect(box1).toEqual(box2); | ||
| } | ||
| }); | ||
| }); |