-
Notifications
You must be signed in to change notification settings - Fork 939
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: added hooks for pyinstaller #812
Conversation
10+ individual users requested it, so makes sense to add support for it. Fixes #513 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, tested with the following test case:
PLAYWRIGHT_BROWSERS_PATH=0 playwright install chromium
pyinstaller -F test.py
- clean browsers to make sure we are not using the wrong ones
PLAYWRIGHT_BROWSERS_PATH=0 ./dist/test
cc: @pavelfeldman |
We can land if you somehow can set the env var for the driver automatically. Like detect somehow if its pyinstaller and then set it. Had an offline discussion with him about it. |
Done! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
For review instructions:
main.py
PLAYWRIGHT_BROWSERS_PATH=0
to include bowser's inside the binary and then download the browsersdist/
relative to current dir and test it