Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: better type annotation for channels #591

Merged
merged 4 commits into from
Mar 24, 2021
Merged

chore: better type annotation for channels #591

merged 4 commits into from
Mar 24, 2021

Conversation

kumaraditya303
Copy link
Contributor

@kumaraditya303 kumaraditya303 commented Mar 22, 2021 •
edited
Loading

Untitled

@kumaraditya303
Copy link
Contributor Author

There are linting issues , not sure what it is

@pavelfeldman
Copy link
Member

You are overwriting recent driver docs with older driver docs. You should run setup.

@kumaraditya303
Copy link
Contributor Author

kumaraditya303 commented Mar 23, 2021 •
edited
Loading

Done!, yet it is failing

@pavelfeldman
Copy link
Member

Well, you are rewriting entire _generated.py files, there should be only channel-related changes there.

@kumaraditya303
Copy link
Contributor Author

Thanks @aslushnikov

@aslushnikov aslushnikov merged commit 1a4bdf7 into microsoft:master Mar 24, 2021
@kumaraditya303 kumaraditya303 deleted the better-type branch March 24, 2021 05:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pavelfeldman pavelfeldman pavelfeldman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kumaraditya303 @pavelfeldman @aslushnikov