Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

devops: separate wheels for OS/drivers #119

Merged

Conversation

mxschmitt
Copy link
Member

@mxschmitt mxschmitt commented Aug 1, 2020

Closes #117

Before:

(env) ➜  playwright-python git:(devops/publish-os-specific) du -sh dist/*
 89M    dist/playwright-0.0.4.post9+g875b380-py3-none-any.whl
 81M    dist/playwright-0.0.4.post9+g875b380.tar.gz

After:

(env) ➜  playwright-python git:(devops/publish-os-specific) ✗ du -sh dist/*          
 24M    dist/playwright-0.0.4.post9+g875b380.d20200801-py3-none-macosx_10_13_x86_64.whl
 26M    dist/playwright-0.0.4.post9+g875b380.d20200801-py3-none-manylinux1_x86_64.whl
 24M    dist/playwright-0.0.4.post9+g875b380.d20200801-py3-none-win_amd64.whl
300K    dist/playwright-0.0.4.post9+g875b380.d20200801.tar.gz

PIP will automatically in the end install the correct wheel since all were uploaded to the PyPi registry.

@coveralls
Copy link

coveralls commented Aug 1, 2020

Pull Request Test Coverage Report for Build 191536671

  • 2 of 4 (50.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.2%) to 88.439%

Changes Missing Coverage Covered Lines Changed/Added Lines %
playwright/main.py 2 4 50.0%
Totals Coverage Status
Change from base Build 191452784: 0.2%
Covered Lines: 3366
Relevant Lines: 3806

💛 - Coveralls

@mxschmitt mxschmitt force-pushed the devops/publish-os-specific branch 2 times, most recently from 2aec2fa to 9d8b64e Compare August 1, 2020 10:57
build_package.py Show resolved Hide resolved
build_package.py Outdated Show resolved Hide resolved
@mxschmitt mxschmitt force-pushed the devops/publish-os-specific branch 12 times, most recently from 87f2317 to c9ad904 Compare August 1, 2020 20:36
@mxschmitt mxschmitt force-pushed the devops/publish-os-specific branch from c9ad904 to 1587e6b Compare August 1, 2020 20:59
@pavelfeldman pavelfeldman merged commit 33afb6c into microsoft:master Aug 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Provide separate wheels for the different operating systems
3 participants