Add PySpark with RasterFrames Support profile #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cleanup Spark cpu pools Expose SparkUI in the spawned notebooks, add more details into the PySpark profile description Add the Spark env init script Add Spark executors template to support nodes tolerations Allocate NoteBooks per namespace Add hub and proxy ClusterRoles Make AKS RBAC enabled Rename ensure_service_account function Change the spark executor image Expose the Spark UI in the pyspark profile case Cleanup hub and autohttps ClusterRoles
|
|
pomadchin
commented
Jan 24, 2022
| @@ -85,10 +85,17 @@ daskhub: | |||
| c.KubeSpawner.extra_labels = {} | |||
| kubespawner: | | |||
| c.KubeSpawner.start_timeout = 15 * 60 # 15 minutes | |||
| # pass the parent namespace through, needed for pre_spawn_hook to copy resources | |||
| c.KubeSpawner.environment['NAMESPACE_PARENT'] = c.KubeSpawner.namespace | |||
There was a problem hiding this comment.
TODO: try the template replacement instead of setting the parent namespace variable.
pomadchin
commented
Jan 24, 2022
| @@ -147,13 +243,31 @@ daskhub: | |||
|
|
|||
| c.KubeSpawner.pre_spawn_hook = pre_spawn_hook | |||
|
|
|||
| # it is the spawner post stop hook, not related to the notebook lifecycle | |||
| # we don't need it | |||
| post_stop_hook: | | |||
There was a problem hiding this comment.
We don't need it here, I will remove it unless we want to keep it here for fun cc @TomAugspurger
pomadchin
commented
Jan 24, 2022
| @@ -23,6 +23,7 @@ module "resources" { | |||
| jupyterhub_singleuser_image_name = "pcccr.azurecr.io/public/planetary-computer/python" | |||
| jupyterhub_singleuser_image_tag = "2022.01.17.0" | |||
| python_image = "pcccr.azurecr.io/public/planetary-computer/python:2022.01.17.0" | |||
| pyspark_image = "daunnc/planetary-computer-pyspark:2021.11.29.0-gdal3.4-3.1-rf" | |||
There was a problem hiding this comment.
TODO: make PRs against MSFTPC repos with containers.
pomadchin
commented
Jan 24, 2022
| 'spark.driver.memory': '1g', | ||
| 'spark.executor.cores': '3', | ||
| 'spark.kubernetes.namespace': namespace_user, | ||
| 'spark.kubernetes.container.image': 'quay.io/daunnc/spark-k8s-py-3.8.8-gdal32-msftpc:3.1.2', |
There was a problem hiding this comment.
Should be replaced by the MSFTPC containers.
pomadchin
commented
Jan 24, 2022
| namespace_user = os.environ.get('NAMESPACE_USER', '') | ||
| spark_config = { | ||
| 'spark.master': 'k8s://https://kubernetes.default.svc.cluster.local', | ||
| 'spark.app.name': 'STAC API with RF in K8S', |
There was a problem hiding this comment.
The Spark app name should probably be picked up from the Notebook name / or used the default one (more Microsofty).
pomadchin
commented
Jan 24, 2022
| default: "True" | ||
| description: '4 cores, 32 GiB of memory. <a href="https://github.com/pangeo-data/pangeo-docker-images" target="_blank">Pangeo Notebook</a> environment powered by <a href="https://rasterframes.io/">Raster Frames</a>, <a href="http://geotrellis.io/">GeoTrellis</a> and <a href="https://spark.apache.org/">Apache Spark</a>.' | ||
| kubespawner_override: | ||
| image: "${pyspark_image}" |
There was a problem hiding this comment.
Note: the only difference between PySpark and Python images is in the amount of the underlying deps.
1 task
pomadchin
commented
Jan 27, 2022
pomadchin
force-pushed
the
feature/pyspark
branch
from
8da4d5f to
c4905a4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adjusts the terraform deployment as well as helmcharts to support the PySpark profile.
Some significant improvements achieved while doing it:
TODO: