Support parsing GCHeapStats_V2 #1295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
18 tasks
cshung
commented
Oct 28, 2020
Maoni0
approved these changes
Oct 28, 2020
brianrob
approved these changes
Oct 28, 2020
cshung
force-pushed
the
public/dev/andrewau/fixpoh
branch
from
07da060
to
7c3d466
Compare
cshung
force-pushed
the
public/dev/andrewau/fixpoh
branch
from
7c3d466
to
e4b9731
Compare
cshung
force-pushed
the
public/dev/andrewau/fixpoh
branch
from
e4b9731
to
12aea05
Compare
cshung
commented
Nov 2, 2020
|
@brianrob This is ready to be merged. |
brianrob
approved these changes
Nov 3, 2020
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dotnet/runtime#34549 introduced
GCHeapStats_V2. The new event requires additional parsing logic to handle the extra fields.The change is driven by adding the
GenerationSize4andTotalPromotedSize4fields toGCHeapStatsTraceDataclass and add the appropriate parsing logic there, the rest is driven by consuming these fields in various places where we consumedGenerationSize3orTotalPromotedSize3.Most of the changes are routine, except one place I marked with a
TODOwhere I am not exactly sure what to do there.I am sure the parsing logic is correct by taking a dump at the point when the event is emitted and comparing the parsed values with the dump. The correctness of the rest is less clear.