Skip to content
This repository has been archived by the owner on Jun 6, 2024. It is now read-only.

Add custom ssl port support. resolves #5386 #5387

Closed
wants to merge 3 commits into from
Closed

Add custom ssl port support. resolves #5386 #5387

wants to merge 3 commits into from

Conversation

siaimes
Copy link
Contributor

@siaimes siaimes commented Mar 22, 2021

Signed-off-by: siaimes <34199488+siaimes@users.noreply.github.com>
@ghost
Copy link

ghost commented Mar 22, 2021

CLA assistant check
All CLA requirements met.

@coveralls
Copy link

coveralls commented Mar 22, 2021

Coverage Status

Coverage remained the same at 34.02% when pulling 01aaac1 on siaimes:master into 7543ac9 on microsoft:master.

siaimes added 2 commits March 22, 2021 10:21
Signed-off-by: siaimes <34199488+siaimes@users.noreply.github.com>
Signed-off-by: siaimes <34199488+siaimes@users.noreply.github.com>
@siaimes
Copy link
Contributor Author

siaimes commented Mar 23, 2021

It seems that port 443 is still occupied, causing additional Nginx services to fail to respond to port 443 requests.

@yiyione yiyione mentioned this pull request May 10, 2021
16 tasks
@Binyang2014
Copy link
Contributor

@siaimes Is this PR still valid? I think you can simply change the hostPort: to your desire port number to achieve this

@siaimes
Copy link
Contributor Author

siaimes commented May 18, 2021

@siaimes Is this PR still valid? I think you can simply change the hostPort: to your desire port number to achieve this

This PR has only been tested in v1.3.0, but there is a problem, and I have not adopted it myself.

I changed the 'hostPort' to '8443', and then started another service at '443'. The result of the experiment is that openpai can be migrated to '8443', but the service of '443' still cannot receive network traffic.

I also think we can simply change 'hostPort' to achieve this feature, but this doesn't seem to work in the v1.3.0 version, So for this PR, contributors may need to do more testing. Thank you.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants