Skip to content
This repository has been archived by the owner on Jun 6, 2024. It is now read-only.

Eng doc update #5240

Merged
merged 5 commits into from
Jan 12, 2021
Merged

Eng doc update #5240

merged 5 commits into from
Jan 12, 2021

Conversation

hzy46
Copy link
Contributor

@hzy46 hzy46 commented Jan 11, 2021

No description provided.

@hzy46
fix
74e806d 
fix

fix

fix

fix
@hzy46 hzy46 requested review from debuggy and suiguoxin January 11, 2021 07:57
@coveralls
Copy link

coveralls commented Jan 11, 2021 •
edited
Loading

Coverage Status

Coverage remained the same at 33.933% when pulling 660301c on hzy46:doc_update into c962e59 on microsoft:master.

@suiguoxin
Copy link
Member

Can we put uninstallation doc for v>= 1.0 and v< 1.0 on the same page ? It will be more clear to me.

@suiguoxin
Copy link
Member

The guide installation-guide is too long to read without a clear navigation bar.
Can we divide the installation from scratch part into 3 pieces : config, install k8s, start services ? And installation FAQs and troubleshooting should be placed under admin-manual->Installation Guide too.

@hzy46
Copy link
Contributor Author

hzy46 commented Jan 11, 2021

The guide installation-guide is too long to read without a clear navigation bar.
Can we divide the installation from scratch part into 3 pieces : config, install k8s, start services ? And installation FAQs and troubleshooting should be placed under admin-manual->Installation Guide too.

Done

@hzy46
Copy link
Contributor Author

hzy46 commented Jan 11, 2021

Can we put uninstallation doc for v>= 1.0 and v< 1.0 on the same page ? It will be more clear to me.

Done

@suiguoxin
Copy link
Member

Please help to update the release wiki after the merge of this PR

@hzy46 hzy46 merged commit 9d7c1ac into microsoft:master Jan 12, 2021
@hzy46
Copy link
Contributor Author

hzy46 commented Jan 12, 2021

Please help to update the release wiki after the merge of this PR

done

@siaimes siaimes mentioned this pull request Jul 20, 2021
Closed
@siaimes siaimes mentioned this pull request Aug 10, 2021
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@suiguoxin suiguoxin suiguoxin approved these changes

@debuggy debuggy Awaiting requested review from debuggy

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hzy46 @coveralls @suiguoxin