Skip to content
This repository has been archived by the owner on Jun 6, 2024. It is now read-only.

Alert Email Template Refine #5064

Merged
merged 9 commits into from
Nov 12, 2020
Merged

Conversation

suiguoxin
Copy link
Member

@suiguoxin suiguoxin commented Nov 9, 2020

Email Examples:
User:
image

Admin:
image

@suiguoxin suiguoxin mentioned this pull request Nov 9, 2020
23 tasks
@coveralls
Copy link

coveralls commented Nov 9, 2020

Coverage Status

Coverage remained the same at 34.103% when pulling a4636e0 on suiguoxin:template-refine into da3abef on microsoft:master.

@suiguoxin suiguoxin requested a review from Binyang2014 November 9, 2020 05:04
@Binyang2014
Copy link
Contributor

Just wondering if we can put all ejs into separate folder, such as template folder and not build them into docker image (We can make them as a configmap and mount into container). So if customer want to change/add some templates, they just need to change some config.

@suiguoxin suiguoxin force-pushed the template-refine branch 2 times, most recently from 7c88db7 to 097d615 Compare November 9, 2020 11:36
@suiguoxin suiguoxin force-pushed the template-refine branch 3 times, most recently from 385afb4 to d0150f7 Compare November 10, 2020 09:07
@suiguoxin suiguoxin force-pushed the template-refine branch 2 times, most recently from 4a01c39 to 7fdf350 Compare November 12, 2020 06:28
@suiguoxin suiguoxin merged commit 9764169 into microsoft:master Nov 12, 2020
@suiguoxin suiguoxin deleted the template-refine branch November 12, 2020 12:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants