This repository has been archived by the owner on Jun 6, 2024. It is now read-only.
update users's own profile: support AAD mode; update extension #5032
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hzy46
approved these changes
Nov 2, 2020
abuccts
reviewed
Nov 3, 2020
Comment on lines
69
to
70
| token.checkAdmin, | ||
| param.validate(userInputSchema.basicAdminUserUpdateInputSchema), |
There was a problem hiding this comment.
change the order to keep consistent?
There was a problem hiding this comment.
change the order to keep consistent?
Auth check should have a higher level of priority than content check. checkAdmin is independent of the input schema, so I think it should be placed before.
There was a problem hiding this comment.
change the order to keep consistent?
Order changed to keep the original logic.
abuccts
approved these changes
Nov 3, 2020
38 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is for release v1.4. Needed for multi-cluster feature.
update users own profile API:
extensionupdatecheckAdminshould be a common logic in token check, whilecheckSelfshould be controller specific since it relies on the request body.