This repository has been archived by the owner on Jun 6, 2024. It is now read-only.
[quick-start] Update hived config for quick-start #4855
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binyang2014
force-pushed
the
binyli/hived_cal
branch
from
86a0c15 to
96b329c
Compare
Binyang2014
changed the title
Binyang2014
changed the title
yqwang-ms
reviewed
Aug 31, 2020
yqwang-ms
reviewed
Aug 31, 2020
yqwang-ms
reviewed
Aug 31, 2020
yqwang-ms
reviewed
Aug 31, 2020
yqwang-ms
reviewed
Aug 31, 2020
yqwang-ms
reviewed
Aug 31, 2020
yqwang-ms
reviewed
Aug 31, 2020
yqwang-ms
reviewed
Aug 31, 2020
yqwang-ms
reviewed
Sep 1, 2020
| @@ -292,16 +291,18 @@ def hived_config_prepare(worker_dict, node_resource_dict, pai_daemon_resource_di | |||
| min_mem = min(min_mem, node_resource_free[key]["mem-resource"] - pai_daemon_resource_dict["mem-resource"] - reserved_mem) | |||
| min_gpu = min(min_gpu, node_resource_free[key]["gpu-resource"]) | |||
| if min_cpu <= 0 or min_mem <= 0: | |||
| logger.error("The node resource is not satisfy minmal requests, we need at least cpu: %s, mem: %sMB", min_cpu, min_mem) | |||
| logger.error("The node resource is not satisfy minmal requests, requests cpu: %s, mem: %sMB", | |||
There was a problem hiding this comment.
Log more statistic such as allocatable, reserved etc to help user understand?
yqwang-ms
approved these changes
Sep 1, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When qos-switch set to true, PAI daemon will requests addition resources.
Take PAI service resources into account when calculate hived config