This repository has been archived by the owner on Jun 6, 2024. It is now read-only.
Add task debug info in job detail page [webportal] #4670
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
debuggy
commented
Jul 5, 2020
debuggy
commented
yqwang-ms
reviewed
Jul 6, 2020
src/webportal/src/app/job/job-view/fabric/job-detail/components/task-role-container-list.jsx
Show resolved
Hide resolved
yqwang-ms
reviewed
Jul 6, 2020
src/webportal/src/app/job/job-view/fabric/job-detail/components/task-role-container-list.jsx
Show resolved
Hide resolved
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
could you rename "Debug Info" to something else? For example, "Diagnosis Information"? |
|
Move Debug Info button to job level? #WontFix |
This comment has been minimized.
This comment has been minimized.
yqwang-ms
reviewed
Jul 6, 2020
| ); | ||
| }, | ||
| }, | ||
| { | ||
| key: 'name', | ||
| name: 'Container ID', | ||
| key: 'completionTime', |
There was a problem hiding this comment.
Add debug info:
currentAttemptLaunchedTime
currentAttemptCompletedTime
accountableRetries #Closed
There was a problem hiding this comment.
Just More Diagnostics?
(BTW, use word Diagnostics to align with Exit Diagnostics) #Closed
yqwang-ms
reviewed
Jul 6, 2020
| }, | ||
| { | ||
| key: 'currentAttemptLaunchedTime', | ||
| name: 'Current Attempt Launched Time', |
There was a problem hiding this comment.
Move currentAttemptLaunchedTime/currentAttemptCompletedTime between createdTime and completionTime? #Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.