This repository has been archived by the owner on Jun 6, 2024. It is now read-only.
delete elasticsearch in rest-server #4302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yqwang-ms
reviewed
Mar 19, 2020
| @@ -55,6 +55,11 @@ webportal: | |||
| uri: https://gerhut.github.io/store/marketplace/plugin.js | |||
| server-port: 9286 | |||
|
|
|||
| internal-storage: | |||
There was a problem hiding this comment.
What if internal-storage=true but postgresql=false?
How about remove internal-storage flag, and just add a field:
internal-storage: postgresql
There was a problem hiding this comment.
It is ok for internal-storage=true and postgresql=false. Since the two components are separate services, it is not convenient to use the config internal-storage: postgresql.
yqwang-ms
approved these changes
Mar 20, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.