This repository has been archived by the owner on Jun 6, 2024. It is now read-only.
Add sshbarrier to ssh plugin #3587
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fanyangCS
reviewed
Sep 6, 2019
| userssh: | ||
| type: string | ||
| value: string | ||
| ``` | ||
| - jobssh: true to enable job container wise ssh, false to disable. | ||
| - sshbarrier: wait until can ssh to all defined taskrole's job containers. Only valid when jobssh is true. |
There was a problem hiding this comment.
please define sshbarrier for the whole job level, instead of the task role level. I mean, you can just define sshbarrier as a boolean, when true, all containers should wait until sshd is ready.
There was a problem hiding this comment.
Now sshbarrier is a boolean to define if barrier is enabled.
Use optional param sshbarriertaskroles to identify specific taskroles that barrier watches to meet advanced requirements.
Binyang2014
reviewed
Sep 10, 2019
Binyang2014
reviewed
Sep 10, 2019
Binyang2014
reviewed
Sep 10, 2019
Binyang2014
reviewed
Sep 10, 2019
Binyang2014
reviewed
Sep 10, 2019
Add error spec for SSH barrier. Refine code based on code review
Binyang2014
reviewed
Sep 10, 2019
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If sshbarrier is defined, the ssh will wait until all configured taskrole containers can be attached.