Skip to content
This repository has been archived by the owner on Jun 6, 2024. It is now read-only.

add wizard page when submitting job #3430

Merged
merged 11 commits into from
Aug 26, 2019
Merged

add wizard page when submitting job #3430

merged 11 commits into from
Aug 26, 2019

Conversation

debuggy
Copy link
Contributor

@debuggy debuggy commented Aug 23, 2019

  1. add wizard page
  2. add single submitting page

Binyang2014
Binyang2014 reviewed Aug 23, 2019
View reviewed changes
Copy link
Contributor

@Binyang2014 Binyang2014 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I'm in submit distributed job page then click the back button in browser. Will redirect to a strange page. Not the submission wizard. I don't know if it is by design.

I think use the different url for wizard and submission job page is better. It will not cause the submission page contain too many components.

@debuggy
Copy link
Contributor Author

debuggy commented Aug 23, 2019

When I'm in submit distributed job page then click the back button in browser. Will redirect to a strange page. Not the submission wizard. I don't know if it is by design.

I think use the different url for wizard and submission job page is better. It will not cause the submission page contain too many components.

This need to resolve a issue about how to redirect to submission page with a yaml file #3308

@hzy46 hzy46 mentioned this pull request Aug 26, 2019
Closed
44 tasks
@debuggy debuggy merged commit 06b5c21 into master Aug 26, 2019
@abuccts abuccts deleted the mintao/wizard branch March 20, 2020 08:34
@hzy46 hzy46 mentioned this pull request Apr 27, 2020
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Binyang2014 Binyang2014 Binyang2014 approved these changes

@abuccts abuccts abuccts approved these changes

@sunqinzheng sunqinzheng Awaiting requested review from sunqinzheng

@hzy46 hzy46 Awaiting requested review from hzy46

@wangdian wangdian Awaiting requested review from wangdian

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@debuggy @Binyang2014 @abuccts