Skip to content
This repository has been archived by the owner on Jun 6, 2024. It is now read-only.

Add design docs for protocol sharing #2141

Closed
wants to merge 3 commits into from
Closed

Conversation

abuccts
Copy link
Member

@abuccts abuccts commented Feb 13, 2019

Add design docs for OpenPAI protocol sharing in marketplace.

Add design docs for OpenPAI protocol sharing in marketplace.
@abuccts abuccts self-assigned this Feb 13, 2019
@coveralls
Copy link

coveralls commented Feb 13, 2019

Coverage Status

Coverage increased (+0.01%) to 52.658% when pulling 0d10d92 on xiongyf/protocol into 291ef10 on pai-proto.

Refine the design docs for protocol and marketplace,
separate the implementation part and reserve minimum features.
The protocol for a specific job can be written as a YAML file, which is called protocol file. A protocol file is valid if and only if it meets the schema in protocol.

To implement the protocol, we need to define the schema for job and validate a YAML file for the pre-defined schema.

Copy link
Member

@scarlett2018 scarlett2018 Feb 18, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To implement the protocol, we need to define the schema for job and validate a YAML file for the pre-defined schema.

define or extend? We have a base PAI protocol, right?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right. This part has been implemented and it refers to existing protocol.

----------

OpenPAI repository is a directory on file system, which contains other reposirory and __valid__ protocol files.
The structure of a repository can be defined by users, through component type, usage, or anything else.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what kind of "other repository" is supported?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a recursive definition, "repository" is "OpenPAI repository".

The root directory of a repository should contain a dot file or dot directory, which records configuration or information of the repository, and indicates that it is a repository. Possible configuration and information could be the repository's protocol files list (to track all files), components content index (to search content easily), information may be needed in the future like version and access details.

To implement the repository, we need to initialize the dot file or directory and update it everytime the repository is accessed.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we draw an architecture or component diagram to illustrate the relationship between protocol, job files, repositories and marketplace?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do have drawn a diagram in previous version. But to keep the design simple in the first stage and reserve minimum features to implement, removed it at present.

Refine marketplace design docs.
@abuccts abuccts closed this Mar 4, 2019
@abuccts abuccts deleted the xiongyf/protocol branch August 19, 2019 05:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants