Remove sensitive fields when the job is completed and deleted (#5289)

microsoft · Feb 7, 2021 · 53dc381 · 53dc381
1 parent edc67c2
commit 53dc381
Showing 1 changed file with 4 additions and 0 deletions.
diff --git a/src/database-controller/src/write-merger/handler.js b/src/database-controller/src/write-merger/handler.js
@@ -93,6 +93,10 @@ async function postWatchEvents(req, res, next) {
           if (snapshot.getState() === 'Completed') {
             // if event is DELETED and the state is Completed, mark apiServerDeleted = true
             internalUpdate.apiServerDeleted = true;
+            // If the job is completed and deleted, we could reset its sensitive fields.
+            internalUpdate.configSecretDef = '';
+            internalUpdate.dockerSecretDef = '';
+            internalUpdate.tokenSecretDef = '';
           } else {
             // Event is DELETED and the state is not Completed.
             // This case could occur when someone deletes the framework in API server directly.