Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document the Graph header files and cleanup some issues. #42

Merged
merged 8 commits into from
Nov 28, 2018

Conversation

skottmckay
Copy link
Contributor

NOTE: The changes to .cc file and files outside of the Graph project are trivial adjustments to some methods using a reference instead of a pointer. As we're about to release now is the time to fix these things.

  • Document the header files for the Graph project
  • Fix some consistency issues to conform to the general approach of using a reference if something is never null to clearly advertise that to calling code.
    • Use reference for return value from ConstNodeIterator::operator* and Graph::AddNode, and in a few other minor places.
  • Fix some naming convention violations
  • Remove unnecessary "::onnxruntime::..." namespace qualifier usage
  • Remove some unused things
  • Fix some Code Analysis warnings
  • Few very minor tweaks

Change NodeConstIterator to return a reference to clearly advertise no nullptr's are going to be returned as it's only iterating valid Nodes.
Fix some code analysis warnings.
Couple more consistency changes.
pranavsharma
pranavsharma previously approved these changes Nov 28, 2018
@skottmckay skottmckay requested a review from a team as a code owner November 28, 2018 11:02
@pranavsharma pranavsharma merged commit bd50598 into master Nov 28, 2018
@skottmckay skottmckay deleted the scmckay/AddDocoToGraphAPI branch November 28, 2018 20:56
tmccrmck pushed a commit to tmccrmck/onnxruntime that referenced this pull request Aug 28, 2019
…filters

Handle empty output_filter field
natke referenced this pull request in natke/onnxruntime Feb 15, 2022
#42)

* Handle OOM when using Percentile calibrator

* minor modification

* Modified code to reflect quantization tool

Co-authored-by: Chi Lo <Chi.Lo@gmail.com>
TedThemistokleous added a commit to TedThemistokleous/onnxruntime that referenced this pull request Jul 4, 2024
…icrosoft#42)

Adds the ability for MIGraphX EP to save off or load compiled models to
save time between inferences.

Via Command line

User should be able to set the save ability with
ORT_MIGRAPHX_SAVE_COMPILED_MODEL
ORT_MIGRAPHX_SAVE_COMPILE_PATH

User should be able to set the load ability with
ORT_MIGRAPHX_LOAD_COMPILED_MODEL
ORT_MIGRAPHX_LOAD_COMPILE_PATH

via Onnxruntime API

migx_save_compiled_model
migx_save_model_name
migx_load_compiled_model
migx_load_model_name

The motivation for this is to leverage MIGraphX's existing API to
save/load models after our compile step of graph optimization. For
larger models or models which were compiled with additional tuning
steps, this saves time after first compile and inference run, and thus
speeds up the user experience in order to encourage development.

---------

Co-authored-by: Ted Themistokleous <tedthemistokleous@amd.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants