Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DEMO] Create suggestions to autofix files #22389

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from
Draft

[DEMO] Create suggestions to autofix files #22389

wants to merge 6 commits into from
+42 −2

Conversation

justinchuby
Copy link
Contributor

No description provided.

github-advanced-security[bot]
github-advanced-security bot found potential problems Oct 10, 2024
View reviewed changes
tools/python/fix_long_lines.py
@@ -10,7 +10,12 @@

from util import logger, run

_log = logger.get_logger("fix_long_lines", logging.INFO)
_log = logger.get_logger("fix_long_lines",

Check warning

Code scanning / lintrunner

RUFF/W291 Warning

Trailing whitespace.
See https://docs.astral.sh/ruff/rules/trailing-whitespace
tools/python/fix_long_lines.py
@@ -10,7 +10,12 @@

from util import logger, run

_log = logger.get_logger("fix_long_lines", logging.INFO)
_log = logger.get_logger("fix_long_lines",

Check warning

Code scanning / lintrunner

RUFF/W293 Warning

Blank line contains whitespace.
See https://docs.astral.sh/ruff/rules/blank-line-with-whitespace
tools/python/fix_long_lines.py
_log = logger.get_logger("fix_long_lines", logging.INFO)
_log = logger.get_logger("fix_long_lines",


Check warning

Code scanning / lintrunner

RUFF/W293 Warning

Blank line contains whitespace.
See https://docs.astral.sh/ruff/rules/blank-line-with-whitespace
tools/python/fix_long_lines.py
_log = logger.get_logger("fix_long_lines",



Check warning

Code scanning / lintrunner

RUFF/W293 Warning

Blank line contains whitespace.
See https://docs.astral.sh/ruff/rules/blank-line-with-whitespace
tools/python/fix_long_lines.py




Check warning

Code scanning / lintrunner

RUFF/W293 Warning

Blank line contains whitespace.
See https://docs.astral.sh/ruff/rules/blank-line-with-whitespace
@justinchuby justinchuby mentioned this pull request Oct 10, 2024
Closed
github-actions[bot]
github-actions bot requested changes Oct 10, 2024
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can commit the suggested changes from lintrunner.

onnxruntime/core/framework/copy.cc Outdated Show resolved Hide resolved
onnxruntime/core/framework/copy.cc Outdated Show resolved Hide resolved
tools/python/fix_long_lines.py
Comment on lines 12 to 19

_log = logger.get_logger("fix_long_lines", logging.INFO)
_log = logger.get_logger("fix_long_lines",




logging.INFO)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
_log = logger.get_logger("fix_long_lines", logging.INFO)
_log = logger.get_logger("fix_long_lines",
logging.INFO)
_log = logger.get_logger("fix_long_lines", logging.INFO)

@justinchuby @github-actions
Apply suggestions from code review
24cbfa4 
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@snnn
Copy link
Member

snnn commented Oct 11, 2024

Nice!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@justinchuby @snnn