Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove failOnStderr from Gradle cmakeCheck #20919

Merged
merged 1 commit into from
Jun 4, 2024
Merged

Remove failOnStderr from Gradle cmakeCheck #20919

merged 1 commit into from
Jun 4, 2024

Conversation

jchen351
Copy link
Contributor

@jchen351 jchen351 commented Jun 4, 2024

Description

Remove failOnStderr from Gradle cmakeCheck

Motivation and Context

The Gradle is still using the deprecated API

@jchen351 jchen351 requested a review from a team as a code owner June 4, 2024 16:32
@snnn
Copy link
Member

snnn commented Jun 4, 2024

The Gradle is still using the deprecated API

What does it mean? Should we upgrade Gradle?

@snnn snnn requested a review from edgchen1 June 4, 2024 17:12
@jchen351
Copy link
Contributor Author

jchen351 commented Jun 4, 2024

The Gradle is still using the deprecated API

What does it mean? Should we upgrade Gradle?

The current stable gradle version is 8.8. But these have to be fixed before gradle 9 is offical released.

@edgchen1
Copy link
Contributor

edgchen1 commented Jun 4, 2024

Is our Gradle code using deprecated APIs which are causing some warning output? If so, what are the deprecated APIs and can our usage of them be updated?

@jchen351
Copy link
Contributor Author

jchen351 commented Jun 4, 2024

Is our Gradle code using deprecated APIs which are causing some warning output? If so, what are the deprecated APIs and can our usage of them be updated?

the usage like project.buildDir need to be changed to project.layout.buildDirectory

@jchen351
Copy link
Contributor Author

jchen351 commented Jun 4, 2024

Will try to fix deprecated Gradle usages in a separated PR

@jchen351 jchen351 merged commit 5faeaf6 into main Jun 4, 2024
155 of 159 checks passed
@jchen351 jchen351 deleted the Cjian/gradle-fix branch June 4, 2024 20:54
@sophies927 sophies927 added the triage:approved Approved for cherrypicks for release label Jun 11, 2024
yf711 pushed a commit that referenced this pull request Jun 18, 2024
### Description
Remove failOnStderr from Gradle cmakeCheck



### Motivation and Context
The Gradle is still using the deprecated API
yf711 pushed a commit that referenced this pull request Jun 18, 2024
### Description
Remove failOnStderr from Gradle cmakeCheck



### Motivation and Context
The Gradle is still using the deprecated API
baijumeswani pushed a commit that referenced this pull request Jun 20, 2024
### Description
Remove failOnStderr from Gradle cmakeCheck



### Motivation and Context
The Gradle is still using the deprecated API
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:1.18.1 triage:approved Approved for cherrypicks for release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants