Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace some old file system calls with C++17 std::filesystem APIs. #19196

Merged
merged 38 commits into from
Mar 9, 2024
Merged

Replace some old file system calls with C++17 std::filesystem APIs. #19196

merged 38 commits into from
Mar 9, 2024

Conversation

snnn
Copy link
Member

@snnn snnn commented Jan 18, 2024 •
edited
Loading

Description

  1. Replace some old file system calls to use C++17 std::filesystem APIs.
  2. Remove tensorflow_C_PACKAGE_PATH cmake option, which was only used in onnxruntime_perf_test and the code is out of maintain.
  3. Excludes onnx_test_runner and onnxruntime_perf_test from iOS build because C++17 filesystem library is not available there

Motivation and Context

@snnn snnn changed the title Replace some old file system calls to use C++17 std::filesystem APIs. Replace some old file system calls with C++17 std::filesystem APIs. Jan 18, 2024
@snnn snnn marked this pull request as ready for review March 1, 2024 00:59
@snnn snnn requested review from mszhanyi, pengwa and fs-eire March 1, 2024 04:37
mszhanyi
mszhanyi previously approved these changes Mar 1, 2024
View reviewed changes
pengwa
pengwa previously approved these changes Mar 1, 2024
View reviewed changes
@snnn snnn dismissed stale reviews from pengwa and mszhanyi via cc23da1 March 5, 2024 00:50
edgchen1
edgchen1 reviewed Mar 5, 2024
View reviewed changes
cmake/onnxruntime_unittests.cmake Outdated Show resolved Hide resolved
cmake/onnxruntime_unittests.cmake Show resolved Hide resolved
onnxruntime/test/providers/cpu/model_tests.cc Outdated Show resolved Hide resolved
@snnn snnn requested a review from edgchen1 March 7, 2024 01:55
@snnn snnn requested a review from edgchen1 March 8, 2024 23:54
@snnn snnn merged commit efad5bb into microsoft:main Mar 9, 2024
94 checks passed
@snnn snnn deleted the snnn/filesystem branch March 9, 2024 17:17
@snnn
Copy link
Member Author

snnn commented Apr 11, 2024

An issue was found: microsoft/onnxruntime-genai#257

@snnn snnn mentioned this pull request Jul 12, 2024
Merged
snnn added a commit that referenced this pull request Jul 15, 2024
@snnn
Fix a path problem in onnxruntime_perf_test (#21341)
dfaf189 
### Description
Resolve #21267 . onnxruntime_perf_test does not work properly if the
input model path url is just a single filename without any path
separator. For example,

```
./onnxruntime_perf_test -t 10 model.onnx
```

The problem was introduced in #19196 by me.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edgchen1 edgchen1 edgchen1 approved these changes

@mszhanyi mszhanyi mszhanyi left review comments

@pengwa pengwa pengwa left review comments

@fs-eire fs-eire Awaiting requested review from fs-eire

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@snnn @pengwa @mszhanyi @edgchen1