Create new stream for data copy for IOBidning input scenario #14719
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Stream* device_stream = nullptr; | ||
| #ifdef ORT_ENABLE_STREAM | ||
| DeviceStreamCollectionHolder device_stream_collection_holder(session_state); | ||
| if (device_stream_collection_holder.p_ != nullptr) { |
| @@ -507,6 +507,48 @@ static common::Status CopyInputsAcrossDevices(const SessionState& session_state, | |||
| return Status::OK(); | |||
| } | |||
|
|
|||
| #ifdef ORT_ENABLE_STREAM | |||
| struct DeviceStreamCollectionHolder { | |||
There was a problem hiding this comment.
Lei just move this func to a new place. the original implementation is to use this holder as a guard to make sure if any error happened we return the device streams to session state correctly.
souptc
approved these changes
Feb 17, 2023
| @@ -507,6 +507,48 @@ static common::Status CopyInputsAcrossDevices(const SessionState& session_state, | |||
| return Status::OK(); | |||
| } | |||
|
|
|||
| #ifdef ORT_ENABLE_STREAM | |||
| struct DeviceStreamCollectionHolder { | |||
There was a problem hiding this comment.
Lei just move this func to a new place. the original implementation is to use this holder as a guard to make sure if any error happened we return the device streams to session state correctly.
|
/azp run MacOS CI Pipeline |
|
Azure Pipelines successfully started running 1 pipeline(s). |
PatriceVignola
pushed a commit
that referenced
this pull request
Feb 22, 2023
### Description Create new stream for data copy for IOBidning input scenario ### Motivation and Context Previously in bindInput(), a nullptr Stream is passed to copy data cross device. This caused the default stream is used thus hurt the performance. This PR is to fix #14484 --------- Co-authored-by: Lei Cao <leca@microsoft.com>
PatriceVignola
pushed a commit
that referenced
this pull request
Feb 22, 2023
### Description Create new stream for data copy for IOBidning input scenario ### Motivation and Context Previously in bindInput(), a nullptr Stream is passed to copy data cross device. This caused the default stream is used thus hurt the performance. This PR is to fix #14484 --------- Co-authored-by: Lei Cao <leca@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Create new stream for data copy for IOBidning input scenario
Motivation and Context
Previously in bindInput(), a nullptr Stream is passed to copy data cross device. This caused the default stream is used thus hurt the performance.
This PR is to fix #14484