Skip to content

Commit

Permalink
Fix a few issues in "Zip-Nuget-Java-Nodejs Packaging Pipeline" (#21014)
Browse files Browse the repository at this point in the history
### Description
Fix a few issues in the Windows TRT job in "Zip-Nuget-Java-Nodejs
Packaging Pipeline":
1. It is a Windows job. It should not use bash(which is usually not
available on Windows).
2. When it sets ADO vars, it missed a semicolon 

Here is the doc of how to set ADO vars via scripts:
https://learn.microsoft.com/en-us/azure/devops/pipelines/process/set-variables-scripts?view=azure-devops&tabs=bash

You could see it needs a semicolon . Without the semicolon , the vars
will have an extra quotation mark in their values.
  • Loading branch information
snnn authored and baijumeswani committed Jun 18, 2024
1 parent 2c9aa73 commit 322d207
Showing 1 changed file with 8 additions and 8 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -35,19 +35,19 @@ steps:

- ${{ if eq(parameters.DownloadTRT, true) }}:
- ${{ if eq(parameters.CudaVersion, '11.8') }}:
- bash: |
echo "##vso[task.setvariable variable=trtCudaVersion]11.8"
- powershell: |
Write-Host "##vso[task.setvariable variable=trtCudaVersion;]11.8"
displayName: Set trtCudaVersion
- ${{ if and(eq(parameters.CudaVersion, '12.2'), eq(parameters.TrtVersion, '8.6.1.6')) }}:
- bash: |
echo "##vso[task.setvariable variable=trtCudaVersion]12.0"
- powershell: |
Write-Host "##vso[task.setvariable variable=trtCudaVersion;]12.0"
displayName: Set trtCudaVersion
- ${{ if and(eq(parameters.CudaVersion, '12.2'), eq(parameters.TrtVersion, '10.0.1.6')) }}:
- bash: |
echo "##vso[task.setvariable variable=trtCudaVersion]12.4"
- powershell: |
Write-Host "##vso[task.setvariable variable=trtCudaVersion;]12.4"
displayName: Set trtCudaVersion
- bash: |
- script: |
echo $(trtCudaVersion) && echo TensorRT-${{ parameters.TrtVersion }}.Windows10.x86_64.cuda-$(trtCudaVersion)
displayName: Get trtCudaVersion and Directory Name
Expand All @@ -63,4 +63,4 @@ steps:
inputs:
script: |
echo %PATH%
displayName: 'Print PATH after download TensorRT'
displayName: 'Print PATH after download TensorRT'

0 comments on commit 322d207

Please sign in to comment.