Add temperature sanity check as 0 is invalid #1211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajindal1
previously approved these changes
Jan 31, 2025
This reverts commit 421026e.
ajindal1
approved these changes
Feb 1, 2025
baijumeswani
pushed a commit
that referenced
this pull request
Feb 3, 2025
A user was passing 0 and this results in a divide by zero in the SoftMax calculation, which results in +INF/NaN floating point results that are not obviously caused by a zero temperature. This lets users know at token selection time that the current temperature is invalid.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A user was passing 0 and this results in a divide by zero in the SoftMax calculation, which results in +INF/NaN floating point results that are not obviously caused by a zero temperature.
This lets users know at token selection time that the current temperature is invalid.