Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Differentiate between release and main branch for running examples #1204

Merged
merged 7 commits into from
Feb 1, 2025
Merged

Differentiate between release and main branch for running examples #1204

merged 7 commits into from
Feb 1, 2025

Conversation

ajindal1
Copy link
Collaborator

Differentiate between release and main branch for running examples as there might be some incompatibility because of new features.

@ajindal1 ajindal1 requested review from natke and Copilot January 27, 2025 23:00
natke
natke reviewed Jan 27, 2025
View reviewed changes
Copy link
Contributor

@natke natke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We would also need similar instructions for the other language examples

@ajindal1
Copy link
Collaborator Author

@natke the steps would remain the same for all the other languages, do you think it would be better to add this on the main README? Just before this

@ajindal1 ajindal1 requested a review from natke January 28, 2025 20:27
natke
natke reviewed Jan 28, 2025
View reviewed changes
Copy link
Contributor

@natke natke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only issue with this approach is that the instructions are for Python, not the other languages

@ajindal1 ajindal1 requested a review from natke January 29, 2025 20:09
@ajindal1 ajindal1 added the 0.6.0 label Feb 1, 2025
@ajindal1 ajindal1 merged commit 8846d0b into main Feb 1, 2025
14 checks passed
@ajindal1 ajindal1 deleted the abjindal/run_examples_doc branch February 1, 2025 20:47
baijumeswani pushed a commit that referenced this pull request Feb 3, 2025
@ajindal1 @baijumeswani
Differentiate between release and main branch for running examples (#…
2bc859a 
…1204)

Differentiate between release and main branch for running examples as
there might be some incompatibility because of new features.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@natke natke natke approved these changes

Copilot code review Copilot Awaiting requested review from Copilot

Assignees
No one assigned
Labels
0.6.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ajindal1 @natke