NPM catalog schema change causes high CPU (#398) #437
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if (!string.IsNullOrEmpty(builder.Name)) { | ||
| var package = builder.Build(); | ||
| InsertCatalogEntry(db, package); | ||
| } |
There was a problem hiding this comment.
We should continue catching the ArgumentException - occasionally npm changes things about their schema (or some odd package gets published that is contrary to the entire schema) that causes us to parse things incorrectly. For instance, at some point a single package was appearing in the catalog with an array of homepages rather than a single list.
In these cases, we want to be able to fail gracefully with a small note about what failed rather than failing to retrieve the entire catalog.
There was a problem hiding this comment.
OK. Added roughly the same logging/handling into the ReadPackage function.
|
left a few comments and lgtm after that |
billti
added a commit
that referenced
this pull request
Sep 10, 2015
NPM catalog schema change causes high CPU (#398)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the fix for the NPM schema change causing the infinite loop and CPU usage - see #398 .
I took the opportunity to reduce the size of some of the test assets for the validation, as they were so huge they took forever to run, and added coverage for the new Array literal schema case. These tests are all passing now.