Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Installer Telemetry #373

Merged
merged 33 commits into from
Aug 27, 2015
Merged

Adding Installer Telemetry #373

merged 33 commits into from
Aug 27, 2015

Conversation

sanyamc-msft
Copy link
Contributor

Adding a Custom Action to send back installer telemetry using http POST.

@msftclas
Copy link

Hi @sanyamc-msft, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. I promise there's no faxing. https://cla.microsoft.com.

TTYL, MSBOT;

@msftclas
Copy link

@sanyamc-msft, Thanks for signing the contribution license agreement so quickly! Actual humans will now validate the agreement and then evaluate the PR.

Thanks, MSBOT;

@@ -0,0 +1,191 @@
using System;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add copyright headers to all new files.


// This version should never change from "4100.00"; BuildRelease.ps1
// will replace it with a generated value.
public const string BuildNumber = "4100.00";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deleting the entire file seems like overkill - all I was saying is not to change the above version string 😃

@mousetraps
Copy link
Contributor

As we just discussed, this is good to go once...

  • AssemblyVersion.cs remains unchanged
  • The binaries that need to be signed are making it into he UnsignedBinaries folder on build (and are being signed)
  • The installer is being properly built with all the binaries it needs.
  • The wix targets file references are functional

@mousetraps
Copy link
Contributor

It would also make merging quicker if you update the PR with the latest changes from NTVS since it's out of date now.

@sanyamc-msft
Copy link
Contributor Author

I have resolved all the issues

  • AssemblyVersion.cs is unchanged
  • InstallerTelemetry is built ONLY for -release and is functional for all 3 (2012,12,15) setup.
  • Wix targets are functional

I will sync with latest NTVS and submit PR for merge.

Details on why it wasn't including telemetryaction.dll:

  • It required CSharp target which wasn't included with setup projects. I have now included the checked in CSharp targets , it does give a compile time warning on release builds because that targets is included later by product but for that we have to modify Product targets file to include if it hasn't already.

@billti
Copy link
Member

billti commented Aug 27, 2015

Thanks! I'll merge this in, kick of a build, and make sure everything is looking good.

billti added a commit that referenced this pull request Aug 27, 2015
@billti billti merged commit 50ee5b4 into microsoft:master Aug 27, 2015
@paulvanbrenk
Copy link
Contributor

The only comment I had was to make sure the { is consistent with the rest of the codebase.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants