-
Notifications
You must be signed in to change notification settings - Fork 357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding Installer Telemetry #373
Conversation
Hi @sanyamc-msft, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution! TTYL, MSBOT; |
@sanyamc-msft, Thanks for signing the contribution license agreement so quickly! Actual humans will now validate the agreement and then evaluate the PR. |
@@ -0,0 +1,191 @@ | |||
using System; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add copyright headers to all new files.
First set of telemetry infrastructure changes
|
||
// This version should never change from "4100.00"; BuildRelease.ps1 | ||
// will replace it with a generated value. | ||
public const string BuildNumber = "4100.00"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Deleting the entire file seems like overkill - all I was saying is not to change the above version string 😃
As we just discussed, this is good to go once...
|
It would also make merging quicker if you update the PR with the latest changes from NTVS since it's out of date now. |
I have resolved all the issues
I will sync with latest NTVS and submit PR for merge. Details on why it wasn't including telemetryaction.dll:
|
…so should be signed automatically
Thanks! I'll merge this in, kick of a build, and make sure everything is looking good. |
The only comment I had was to make sure the |
Adding a Custom Action to send back installer telemetry using http POST.