Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to branch blacklist for main appveyor build definition #1388

Closed
mjbvz opened this issue Oct 24, 2016 · 0 comments
Closed

Switch to branch blacklist for main appveyor build definition #1388

mjbvz opened this issue Oct 24, 2016 · 0 comments

Comments

@mjbvz
Copy link
Contributor

mjbvz commented Oct 24, 2016

Bug

We want appveyor to run for PRs against branches such as vs-15 and test-adapter-improvements. It currently is not run because we use a whitelist of branches to define when the build should be run. You have to manually opt in these branches.

Fix

Change our main build definition to use a blacklist instead to define which branches the main build should not be run for. This change would only be for the main build, not any of the branch/version specific ones.

mjbvz added a commit to mjbvz/nodejstools that referenced this issue Oct 24, 2016
**Bug**
Issue microsoft#1388. Some of our branches (such as feature branches) are currently not built by appveyor because we use a branch whitelist. We have to opt new branches into the build.

**Fix**
Change the main build to use a blacklist instead. Also gives the `v1.2.x` branch it's own build definition.
mjbvz added a commit that referenced this issue Oct 24, 2016
**Bug**
Issue #1388. Some of our branches (such as feature branches) are currently not built by appveyor because we use a branch whitelist. We have to opt new branches into the build.

**Fix**
Change the main build to use a blacklist instead. Also gives the `v1.2.x` branch it's own build definition.
mjbvz added a commit that referenced this issue Oct 24, 2016
This will make the branch build on appveyor.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant