Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix releasing to public ADO feeds #424

Merged
merged 1 commit into from
Feb 4, 2025

Conversation

vmoroz
Copy link
Member

@vmoroz vmoroz commented Feb 4, 2025

There were issues publishing Nuget to ADO public feed after getting the permissions for the initial pipeline run.

The solution was to add the undocumented publishFeedCredentials property to the 1ES.PublishNuGet@1 task as it was on the original NuGetCommand@2 task.
Another issue was that the packagesToPush was missing the leading folder path.
The PR also has some other non-significant changes needed to debug the issue and a few stylistic touches.

I had verified that the new code was successful to publish the new version 9.0.2 in manual mode.

@vmoroz vmoroz requested review from dannyvv and jasongin February 4, 2025 21:13
@vmoroz vmoroz merged commit 956d1b1 into microsoft:main Feb 4, 2025
24 checks passed
@vmoroz vmoroz deleted the PR/fix_release_to_ADO_feeds branch February 4, 2025 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants