This repository has been archived by the owner on Sep 18, 2024. It is now read-only.
flops counter formatting fix #3837
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
J-shang
approved these changes
Jun 16, 2021
ultmaster
reviewed
Jun 21, 2021
| @@ -313,12 +313,13 @@ def format_results(self): | |||
|
|
|||
| table.field_names = headers | |||
| for i, result in enumerate(self.results): | |||
| flops_count = int(result['flops'].item()) if isinstance(result['flops'], torch.Tensor) else int(result['flops']) | |||
There was a problem hiding this comment.
It seems that line 366 in the same file also uses isinstance for checking. Also, do we need to consider the recommendation from the official website? https://pytorch.org/docs/stable/generated/torch.is_tensor.html
There was a problem hiding this comment.
In the official recommendation is isinstance, I'm okay with that.
ultmaster
approved these changes
Jun 21, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a minor formatting issue. Previously the counter prints out the FLOPs as a tensor directly.
before:
after: