This repository has been archived by the owner on Sep 18, 2024. It is now read-only.
support shared storage for reusable mode #3354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
94 tasks
liuzhe-lz
reviewed
Feb 19, 2021
| sudo rpm -Uvh https://packages.microsoft.com/config/rhel/$(echo $version | cut -c1)/packages-microsoft-prod.rpm | ||
| sudo yum install -y blobfuse fuse | ||
| else | ||
| echo "Not support distributor." |
There was a problem hiding this comment.
I feel uncomfortable about this...
liuzhe-lz
reviewed
Feb 24, 2021
| @@ -0,0 +1,50 @@ | |||
| **How to Use Shared Storage** | |||
There was a problem hiding this comment.
Please explicitly list supported distros and state that it requires root privilege.
liuzhe-lz
approved these changes
Feb 25, 2021
SparkSnail
reviewed
Feb 25, 2021
| #!/bin/bash | ||
| if [ -n "$(command -v apt-get)" ] | ||
| then | ||
| sudo apt-get update |
There was a problem hiding this comment.
If user's os already installed NFS, these bash script does not need to be executed.
There was a problem hiding this comment.
Add a if [ -n "$(command -v nfsstat)" ] judgment
SparkSnail
reviewed
Feb 25, 2021
| storageAccountKey: ${replace_to_your_storageAccountKey} | ||
| # If you did not set storageAccountKey, you need use `az login` with Azure CLI at first and set resourceGroupName. | ||
| # resourceGroupName: ${replace_to_your_resourceGroupName} | ||
| containerName: ${replace_to_your_containerName} |
There was a problem hiding this comment.
What does containerName mean? Is it a contain id?
There was a problem hiding this comment.
The name of the container in blob service in your storage account, like nni.
SparkSnail
reviewed
Feb 25, 2021
|
|
||
| .. code-block:: yaml | ||
|
|
||
| sharedStorage: |
There was a problem hiding this comment.
add doc for these new added configuration in ExperimentConfig.rst?
SparkSnail
approved these changes
Feb 25, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[storage]
[training service]
[others]