This repository has been archived by the owner on Sep 18, 2024. It is now read-only.
Merge .config & nni.sqlite #3309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
94 tasks
SparkSnail
reviewed
Jan 19, 2021
nni/tools/nnictl/nnictl_utils.py
Outdated
| break | ||
| elif not args.searchSpacePath: | ||
| print_warning('%s exist, will not load search_space file' % target_path) | ||
| # archive_search_space_dir = os.path.join(temp_root_dir, 'searchSpace') |
There was a problem hiding this comment.
Why annotate them? If these code are not used anymore, you could delete them directly.
There was a problem hiding this comment.
yes, search space file does not need a copy anymore, have deleted them.
SparkSnail
reviewed
Jan 20, 2021
| from .command_utils import print_error | ||
| from .common_utils import get_file_lock | ||
|
|
||
| def config_v0_to_v1(config: dict) -> dict: |
There was a problem hiding this comment.
v0 means the config format in nni.sqlite (clusterMetaData), will be deprecated soon.
liuzhe-lz
reviewed
Jan 22, 2021
nni/tools/nnictl/config_utils.py
Outdated
| '''refresh to get latest config''' | ||
| sql = 'select * from ExperimentProfile where id=? order by revision DESC' | ||
| args = (self.experiment_id,) | ||
| self.config = config_v0_to_v1(json.loads(self.cursor.execute(sql, args).fetchall()[0][0])) |
There was a problem hiding this comment.
- Don't use
self.cursor. One cursor per query to avoid potential racing. select COLUMN_NAMEshould be preferred overselect *, in case the table is altered in future..fetchall()[0]should be.fetchone()
liuzhe-lz
reviewed
Jan 22, 2021
| @@ -624,26 +618,25 @@ def create_experiment(args): | |||
| def manage_stopped_experiment(args, mode): | |||
| '''view a stopped experiment''' | |||
| update_experiment() | |||
| experiment_config = Experiments() | |||
| experiment_dict = experiment_config.get_all_experiments() | |||
| experiments_config = Experiments() | |||
There was a problem hiding this comment.
I personally suggest rename "config" to "metadata" or "metainfo".
Not mandatory if you think "config" is better.
liuzhe-lz
approved these changes
Jan 22, 2021
SparkSnail
approved these changes
Jan 22, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.