This repository has been archived by the owner on Sep 18, 2024. It is now read-only.
Add custom op support of counter #2795
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liuzhe-lz
reviewed
Aug 14, 2020
ultmaster
reviewed
Aug 24, 2020
liuzhe-lz
reviewed
Aug 31, 2020
ultmaster
approved these changes
Sep 7, 2020
chicm-ms
reviewed
Sep 7, 2020
QuanluZhang
reviewed
Sep 9, 2020
chicm-ms
approved these changes
Sep 14, 2020
added 2 commits
September 14, 2020 16:37
liuzhe-lz
reviewed
Sep 20, 2020
| Parameters | ||
| --------- | ||
| model : nn.Module | ||
| target model. | ||
| input_size: list, tuple | ||
| the input shape of data | ||
|
|
||
|
|
||
| custom_ops: dict |
There was a problem hiding this comment.
Suggest to document "dict of what"
There was a problem hiding this comment.
agree, @colorjam suggest to give detailed example of how custom_ops looks like.
There was a problem hiding this comment.
I mentioned the mapping below, and add a reference to custom_mask_ops. Please review the latest version, thanks~
liuzhe-lz
approved these changes
Sep 20, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.