This repository has been archived by the owner on Sep 18, 2024. It is now read-only.
deal with all type metrics #2782
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ultmaster
approved these changes
Aug 12, 2020
liuzhe-lz
reviewed
Aug 12, 2020
| @@ -99,14 +102,22 @@ class App extends React.Component<{}, AppState> { | |||
| this.setState({ bestTrialEntries: entries }); | |||
| } | |||
|
|
|||
| shouldComponentUpdate(nextProps: any, nextState: AppState): boolean { | |||
There was a problem hiding this comment.
If don't use shouldComponentUpdate, parent App.tsx component will refresh three times when experiment done, and then child components will also refresh. And App.tsx's shouldComponentUdate only watch a boolean value.
liuzhe-lz
reviewed
Aug 12, 2020
| @@ -177,8 +187,7 @@ class App extends React.Component<{}, AppState> { | |||
| // experiment status and /trial-jobs api's status could decide website update | |||
| if (['DONE', 'ERROR', 'STOPPED'].includes(EXPERIMENT.status) || TRIALS.jobListError()) { | |||
| // experiment finished, refresh once more to ensure consistency | |||
| this.setState({ interval: 0 }); | |||
| this.lastRefresh(); | |||
There was a problem hiding this comment.
I wrote lastRefresh because due to async nature when experiment status become DONE, some state may have not updated to their final value yet. For example maybe the last trial is still running at previous /trial-jobs REST call.
liuzhe-lz
reviewed
Aug 12, 2020
| @@ -84,15 +84,18 @@ const getFinalResult = (final?: MetricDataRecord[]): number => { | |||
| } | |||
| }; | |||
|
|
|||
| function isNaNorInfinity(val: number): boolean { | |||
| return Object.is(val, NaN) || Object.is(val, Infinity); | |||
There was a problem hiding this comment.
I think Number.isNaN and Number.isFinite is more clear for this purpose.
liuzhe-lz
reviewed
Aug 12, 2020
| let accuracy; | ||
| if(this.acc !== undefined && this.acc.default !== undefined){ | ||
| if(typeof this.acc.default === 'number'){ | ||
| accuracy = JSON5.parse(this.acc.default); |
There was a problem hiding this comment.
to fix this state: when user give final result as {tensor: xxx, data: xxx}
liuzhe-lz
reviewed
Aug 12, 2020
| if (tempHyper === undefined) { | ||
| throw new Map([['error', 'This trial\'s parameters are not available.']]); | ||
| if (this.info === undefined || this.info.hyperParameters === undefined) { | ||
| throw new Map(); |
liuzhe-lz
approved these changes
Aug 12, 2020
LovPe
pushed a commit
to LovPe/nni
that referenced
this pull request
Aug 17, 2020
* update * update * Fix metrics for type other than number * update * change master version TableList.tsx * revert unuseful change Co-authored-by: Lijiao <Lijiaoa@outlook.com> Co-authored-by: Lijiao <1425861283@qq.com> Co-authored-by: Yuge Zhang <scottyugochang@gmail.com> (cherry picked from commit e2a8689)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.