Skip to content
This repository has been archived by the owner on Sep 18, 2024. It is now read-only.

Support multiphase in PAIK8S #2368

Merged
merged 45 commits into from
Apr 30, 2020
Merged

Conversation

SparkSnail
Copy link
Contributor

No description provided.

SparkSnail and others added 30 commits August 6, 2019 18:58
Filter prune algo implementation (microsoft#1655)
Support monitor mode when creating or resuming a new experiment (microsoft#1933)
Add test for documentation build (microsoft#1924)
if (trialJobDetail === undefined) {
throw new Error(`updateTrialJob failed: ${trialJobId} not found`);
}
// Write file content ( parameter.cfg ) to working folders
await this.writeParameterFile(trialJobDetail.logPath, form.hyperParameters);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why write to logPath instead of trail job's working directory?

Copy link
Contributor Author

@SparkSnail SparkSnail Apr 24, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This path will synchronize parameter files in local to docker container, it is the working directory for PAI in docker container.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

then is trialjob.workingDirectory useful now?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In PAITrainingService, there are two directories. One is workingDirectory, this directory stores nniManager logs and datastore data, the default path is located in ~/nni/experiments/{experimentId}. Another path is logPath, which could synchronize data with docker container, store output data from trial and parameter files, the default path is located in {nniManagerNFSMountPath}/{experimentId}/{trialId}. The parameter.cfg file should be put in logPath folder instead of workingDirectory .

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SparkSnail so why not merge the two directory together? according to my understanding in local mode there is only one directory right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed offline, NNI maintains workingDirectory and logPath in PAI mode. This structure maybe need refactor, this pr will keep current logic temporarily.

@chicm-ms
Copy link
Contributor

please enable multiphase test case in pai and pai-windows pipeline

@SparkSnail
Copy link
Contributor Author

please enable multiphase test case in pai and pai-windows pipeline

fixed.

@QuanluZhang
Copy link
Contributor

@SparkSnail is there UT or IT for testing multiphase on paiK8S?

@SparkSnail
Copy link
Contributor Author

@SparkSnail is there UT or IT for testing multiphase on paiK8S?

Yes, pipeline has enabled multiphase examples on paiK8S in this pr.

@SparkSnail SparkSnail merged commit 2b77ab2 into microsoft:master Apr 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants