This repository has been archived by the owner on Sep 18, 2024. It is now read-only.
Fix NaN support #2077
Merged
Fix NaN support #2077
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chicm-ms
approved these changes
Feb 18, 2020
liuzhe-lz
reviewed
Feb 19, 2020
| @@ -557,7 +557,8 @@ def handle_report_metric_data(self, data): | |||
| Data type not supported | |||
| """ | |||
| logger.debug('handle report metric data = %s', data) | |||
|
|
|||
| if 'value' in data: | |||
| data['value'] = json_tricks.loads(data['value']) | |||
There was a problem hiding this comment.
Is there any documentation affected?
There was a problem hiding this comment.
This is a key/value from data, which is changed from obj to string, I think this is not documented before. But we should document it at somewhere BTW.
liuzhe-lz
approved these changes
Feb 19, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.